Implement Bot API 7.0 #300
Conversation
| @@ -5,7 +5,7 @@ module Bot | |||
| module Types | |||
| class KeyboardButton < Base | |||
| attribute :text, Types::String | |||
| attribute? :request_user, KeyboardButtonRequestUser | |||
| attribute? :request_users, KeyboardButtonRequestUsers | |||
There was a problem hiding this comment.
Should we really replace (remove the old one)?
The old name will still work for backward compatibility.
There was a problem hiding this comment.
TBH, I don't know if we should. I plan to release it with 2.0 version, so breaking changes are possible. What do you think?
There was a problem hiding this comment.
I see nothing what would break this library. I think the deletion of the old name will be in a new API release. But… it's just for backward compatibility, and we have our own, so it's up to you.
I personally see request_user with KeyboardButtonRequestUsers type kind of confusing.
| attribute :request_id, Types::Integer | ||
| attribute? :user_is_bot, Types::Bool | ||
| attribute? :user_is_premium, Types::Bool | ||
| attribute? :max_quantity, Types::Integer |
There was a problem hiding this comment.
I'd add the default and probably even range validation:
1-10. Defaults to 1.
| @@ -7,7 +7,7 @@ class KeyboardButtonRequestUsers < Base | |||
| attribute :request_id, Types::Integer | |||
| attribute? :user_is_bot, Types::Bool | |||
| attribute? :user_is_premium, Types::Bool | |||
| attribute? :max_quantity, Types::Integer.constrained(gteq: 1, lteq: 10).default(1) | |||
There was a problem hiding this comment.
Why a such "fix"? I'd leave the logic and change the specs.
There was a problem hiding this comment.
I'm too lazy to fix the specs for now. You're free to push changes if you want.
No description provided.